[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:362
+def TargetAArch64 : TargetArch<["aarch64"]>;
+def TargetARM_AArch64 : TargetArch<!listconcat(TargetARM.Arches, TargetAArch64.Arches)>;
 def TargetAVR : TargetArch<["avr"]>;
----------------
nit: don't thin we use underscores in names, and looking at examples below, I guess this should be `TargetAnyARM`


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:105
 
+  std::string str() const;
+
----------------
nit: add a comment here too (for consistency)


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:634
         " *\n"
         " * Permission is hereby granted, free of charge, to any person "
         "obtaining "
----------------
Unrelated to this change, I just spotted it because it looked a bit messy, but is this the old copyright header? While we are at it, replace this with the new one? Looks like e.g. in arm_mve.h, we do use the new one. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75861/new/

https://reviews.llvm.org/D75861