[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

Evandro Menezes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 10 12:33:57 PDT 2020


evandro added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:2958
+
+Put global and static data smaller than the limitation into a special section (RISC-V only)
+
----------------
```
s/arg/limit/
s/limitation/limit/
```


================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:403
+def warn_drv_unsupported_g : Warning<
+  "ignoring '-G' option as -msmall-data-limit= in the command line">,
+  InGroup<OptionIgnored>;
----------------
Rather:

```
"ignoring '-G' with '-msmall-data-limit'"
```


================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:406
+def warn_drv_unsupported_sdata : Warning<
+  "ignoring '-msmall-data-limit=' for -fpic or RV64 with -mcmodel=large">,
+  InGroup<OptionIgnored>;
----------------
Rather:

```
"ignoring '-msmall-data-limit=' with '-mcmodel=large' for PIC or RV64"
```


================
Comment at: clang/include/clang/Driver/CC1Options.td:317
+def msmall_data_limit : Separate<["-"], "msmall-data-limit">,
+  HelpText<"Put global and static data smaller than the limitation into a special section">;
 def munwind_tables : Flag<["-"], "munwind-tables">,
----------------
```
s/limitation/limit/
```


================
Comment at: clang/include/clang/Driver/Options.td:2302
+def msmall_data_limit_EQ : Joined<["-"], "msmall-data-limit=">, Group<m_riscv_Features_Group>,
+  HelpText<"Put global and static data smaller than the limitation into a special section">;
 def msave_restore : Flag<["-"], "msave-restore">, Group<m_riscv_Features_Group>,
----------------
```
s/limitation/limit/
```






Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57497/new/

https://reviews.llvm.org/D57497





More information about the cfe-commits mailing list