[PATCH] D75927: [clangd] Use a separate RunningTask flag instead of leaving a broken request on top of the queue
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 10 10:19:40 PDT 2020
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:376
Notification Start;
- updateWithDiags(S, Path, "a", WantDiagnostics::Yes, [&](std::vector<Diag>) {
- ++Builds;
- Start.wait();
- });
+ updateWithDiags(S, Path, "b", WantDiagnostics::Auto,
+ [&](std::vector<Diag>) { ++Builds; });
----------------
sammccall wrote:
> does this deliberately match "b" below? if not, change back to something unique?
> If so, probably needs a comment.
no it wasn't intentional just copy paste ..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75927/new/
https://reviews.llvm.org/D75927
More information about the cfe-commits
mailing list