[PATCH] D75917: Expose llvm fence instruction as clang intrinsic
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 10 09:46:35 PDT 2020
Anastasia added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:1880
+ // Check if Order is an unsigned
+ if (!Ty->isIntegerType()) {
+ Diag(ArgExpr->getExprLoc(), diag::err_typecheck_expect_uint) << Ty;
----------------
JonChesterfield wrote:
> isIntegerType will return true for signed integers as well as unsigned. It seems reasonable to call this with a signed integer type (e.g. '2'), so perhaps the references to unsigned should be dropped from the code and error message
>
I think we should accept implicit type conversion rules from the language...
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75917/new/
https://reviews.llvm.org/D75917
More information about the cfe-commits
mailing list