[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

Dmitry Polukhin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 10 08:07:05 PDT 2020


DmitryPolukhin added a comment.

In D75184#1912650 <https://reviews.llvm.org/D75184#1912650>, @njames93 wrote:

> How are local and global options handled. 
>  From what I can gather it will read the value as `1` as the local option is checked first no matter which file it was defined in.


You are absolutely right about current behaviour. Thank you for catching this odd behaviour. I'm not 100% confident what is the right behaviour but my guess is that overriding local option from parent config with global from child folder is better so I implemented it and added corresponding test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75184/new/

https://reviews.llvm.org/D75184





More information about the cfe-commits mailing list