[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 10 08:06:59 PDT 2020


Szelethus requested changes to this revision.
Szelethus added a comment.
This revision now requires changes to proceed.

We should totally dedicate an error kind of `fseek`, see (and please respond, if you could to) D75356#inline-689287 <https://reviews.llvm.org/D75356#inline-689287>.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:382-384
+  C.addTransition(StateNotFailed);
+  C.addTransition(StateFailedWithFError);
+  C.addTransition(StateFailedWithoutFError);
----------------
This seems a bit excessive, we could merge the last two into `FSeekError`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75851/new/

https://reviews.llvm.org/D75851





More information about the cfe-commits mailing list