[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 10 05:12:15 PDT 2020


balazske marked 3 inline comments as done.
balazske added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:3638
+  /// Number of similar looking friends.
+  unsigned int TotalCount;
+  /// Index of the specific FriendDecl.
----------------
shafik wrote:
> `uint32_t`
> 
> Is there a reason to not prefer fixed width integer types?
I do not know about any reason, but in //ASTImporter.cpp// `uint32_t` does not appear but `unsigned` and `unsigned int` yes. Why can be fixed width type better that the default-sized int?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75740/new/

https://reviews.llvm.org/D75740





More information about the cfe-commits mailing list