[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 10 03:46:42 PDT 2020
martong marked 2 inline comments as done.
martong added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:8132
+ return VisitTypeSpecTypeLoc(FTS);
+ llvm_unreachable("Unimplemented TypeLoc visitor function");
+ }
----------------
balazske wrote:
> This assert is new related to the old code. Are really all TypeLoc's are implemented (probably analyze with CTU a large project)?
Yeah, I am not going to commit this, until our full CI job is green on the change. That job analyzes Tmux, Redis, Curl, Xercex, Bitcoin and Protobuf and considered as a quite good coverage for the Analyzer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71018/new/
https://reviews.llvm.org/D71018
More information about the cfe-commits
mailing list