[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Vince Bridgers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 9 10:14:22 PDT 2020


vabridgers added a comment.
Herald added a subscriber: danielkiss.

@Charusso, I cannot find a way to create a test for this change, since this was found using an architecture that supports 16-bit chars. I understand the need to create test cases for changes. In this case, I believe a rationale for accepting this change is to conform to the C Standard, and accept that upstream clang does not have a way to test for architectures supporting 16-bit characters, or otherwise "peculiar" datatypes.

Please do indicate if you're willing to accept this patch or not. If not, I need to know so I solve this problem for my customer in a different way.

Thank you - Vince


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75529/new/

https://reviews.llvm.org/D75529





More information about the cfe-commits mailing list