[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

[Simon Tatham via Phabricator via cfe-commits]

simon_tatham requested changes to this revision.
simon_tatham added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/include/clang/Basic/TargetInfo.h:213
 
+  unsigned ARMCDECorpocMask : 8;
+
----------------
Typo: `Corpoc` → `Coproc`. Lots of those throughout this patch.


================
Comment at: clang/test/Preprocessor/arm-target-features.c:807
+// CHECK-V8M-NOCDE-NOT: #define __ARM_FEATURE_CDE
+// CHECK-V8M-NOCDE-NOT: #define __ARM_FEATURE_CDE_CORPOC
+// RUN: %clang -target arm-arm-none-eabi -march=armv8m.main+cdecp0+cdecp1+cdecp7 -x c -E -dM %s -o - | FileCheck -match-full-lines --check-prefix=CHECK-V8M-CDE-MASK1 %s
----------------
Especially important not to test for the //absence// of a misspelled macro – that can lead to false-positive test passes!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75843/new/

https://reviews.llvm.org/D75843