[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 9 06:57:32 PDT 2020


njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.

LGTM

However, how does this handle cases when the type is written as `char`. They can be signed/unsigned based on what platform is being targeted. But on a platform where `char` is signed, comparison to an `unsigned char` is dangerous and the complimented case is the same. Surely any `char` comparison to `signed char` or `unsigned char` should be warned. But I'm not sure if that's in the scope of this check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75749/new/

https://reviews.llvm.org/D75749





More information about the cfe-commits mailing list