[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 9 06:57:28 PDT 2020
njames93 accepted this revision.
njames93 added a comment.
LGTM
================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46
bool parseFileExtensions(StringRef AllFileExtensions,
- FileExtensionsSet &FileExtensions, char Delimiter);
+ FileExtensionsSet &FileExtensions,
+ StringRef Delimiters);
----------------
Doesn't belong in this patch, but this function should be changed in a follow up to return an `Optional<FileExtensionSet>`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75621/new/
https://reviews.llvm.org/D75621
More information about the cfe-commits
mailing list