[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <<

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 9 04:48:12 PDT 2020


njames93 marked an inline comment as done.
njames93 added inline comments.


================
Comment at: clang/include/clang/Basic/Diagnostic.h:1318
+                                           const llvm::Optional<T> &Opt) {
+  if (Opt) {
+    DB << *Opt;
----------------
Should this be disabled on functions that pass format args to the diagnostic so it will only optionally add things FixIts, Notes, Ranges...?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75714/new/

https://reviews.llvm.org/D75714





More information about the cfe-commits mailing list