[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 9 04:16:25 PDT 2020
martong marked 2 inline comments as done.
martong added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511
+ //
+ // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't
+ // take arguments and doesn't model parameter initialization because there is
----------------
NoQ wrote:
> I'd rather put this Richard's comment somewhere near the respective `CallEvent` definition. We clearly don't need to analyze these functions, so it doesn't really matter for anybody who reads this code that there are temporary technical difficulties with analyzing them. On the other hand, it does matter a lot for people who try to understand how to implement the call event correctly.
Ok, I moved this part of the comment into CallEvent.h .
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75678/new/
https://reviews.llvm.org/D75678
More information about the cfe-commits
mailing list