[PATCH] D75700: [NFC] Let mangler accept GlobalDecl
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 7 11:23:14 PST 2020
rjmccall accepted this revision.
rjmccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/AST/ItaniumMangle.cpp:1563
+ else
+ GD = GlobalDecl(dyn_cast<FunctionDecl>(DC));
+ return GD;
----------------
rjmccall wrote:
> `cast`? But I'm not sure this is true, local entities can be in non-function declarations: blocks, ObjC methods, and captured statements. You can just `cast<Decl>(DC)`.
I guess we just never enter this for local names within ObjC methods or blocks?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75700/new/
https://reviews.llvm.org/D75700
More information about the cfe-commits
mailing list