[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

In D75209#1910047 <https://reviews.llvm.org/D75209#1910047>, @ABataev wrote:

> In D75209#1909976 <https://reviews.llvm.org/D75209#1909976>, @jdoerfert wrote:
>
> > I am unsure we need this with the proper math support. Sema patch for that is going for review today. I'll try this out soon.
>
>
> It has nothing to do with the math functions support. These functions are required for the definition of __muldc3/__divdc3/__mulsc2/__divsc3 functions emitted for the complex types. CUDA does absolutely the same.


The fact that CUDA does the same is the important part here. Why should we copy it then? See https://reviews.llvm.org/D75788#change-0Ax9LSfw7OAk for working support of complex math functions in target regions without copying what cuda does but by just using it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75209/new/

https://reviews.llvm.org/D75209