[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 7 09:08:22 PST 2020


NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511
+  //
+  // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't
+  // take arguments and doesn't model parameter initialization because there is
----------------
I'd rather put this Richard's comment somewhere near the respective `CallEvent` definition. We clearly don't need to analyze these functions, so it doesn't really matter for anybody who reads this code that there are temporary technical difficulties with analyzing them. On the other hand, it does matter a lot for people who try to understand how to implement the call event correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75678/new/

https://reviews.llvm.org/D75678





More information about the cfe-commits mailing list