[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 6 18:47:12 PST 2020
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107
+
+ Moved fuchsia's restrict-system-includes check to portability to allow for
+ general use.
----------------
I don't think that this statement is necessary.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:10
+
+In order to **only** allow zlib.h from the system you would set the options to
+`-*,zlib.h`.
----------------
Please highlight zlib.h with single back-ticks.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:20
+
+In order to allow everything **except** zlib.h from the system you would set
+the options to `*,-zlib.h`.
----------------
Please highlight zlib.h with single back-ticks.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:50
+ filenames. Similar to the -checks glob list for running clang-tidy itself,
+ the two wildcard characters are '*' and '-', to include and exclude globs,
+ respectively. The default is '*', which allows all includes.
----------------
Please use single back-ticks for highlighting options values. Same above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75786/new/
https://reviews.llvm.org/D75786
More information about the cfe-commits
mailing list