[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 6 16:34:16 PST 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

I re-read Richard's comment:

> Would it make sense to put the MS extension warning into the -Wpointer-to-int-cast group so that we can control this warning consistently across platforms? You could get that effect by introducing a new warning group (eg, "-Wmicrosoft-pointer-to-int-cast") containing just the ExtWarn warning, and putting that group in both MicrosoftCast and PointerToIntCast.

My interpretation is that he was **suggesting** the change that you are making here. So, let's continue without his additional approval.

I'll go ahead and push this in a minute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75643/new/

https://reviews.llvm.org/D75643





More information about the cfe-commits mailing list