[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

Fri Mar 6 14:23:03 PST 2020

aeubanks added a comment.

Specifically regarding
../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *',
I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with ToT clang with the suppression removed, then there were no more errors.

Anyway, we should probably be consistent between this and https://reviews.llvm.org/D75643. I'm fine with keeping what we have, but then https://reviews.llvm.org/D75643 should probably go in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75752/new/

https://reviews.llvm.org/D75752