[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline
Nick Desaulniers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 6 13:48:31 PST 2020
nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:15
-def warn_asm_qualifier_ignored : Warning<
- "ignored %0 qualifier on asm">, CatInlineAsm, InGroup<ASMIgnoredQualifier>;
-def warn_file_asm_volatile : Warning<
- "meaningless 'volatile' on asm outside function">, CatInlineAsm,
- InGroup<ASMIgnoredQualifier>;
+def err_file_asm_volatile : Error<
+ "meaningless '%0' on asm outside function">, CatInlineAsm;
----------------
oh, I meant to rename this; and I think flipping the order of this and following def is a little clearer for code review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75563/new/
https://reviews.llvm.org/D75563
More information about the cfe-commits
mailing list