[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

Fri Mar 6 13:48:23 PST 2020

erichkeane added a comment.

In D75768#1910324 <https://reviews.llvm.org/D75768#1910324>, @jstenglein wrote:

> In D75768#1910303 <https://reviews.llvm.org/D75768#1910303>, @erichkeane wrote:
>
> > Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful.  Otherwise I think this patch looks fine.
>
>
> Thanks for the comments.  It is already part of -Wall since I put it in -Wmost and -Wall includes -Wmost:
>  def All : DiagGroup<"all", [Most, Parentheses, Switch, SwitchBool, MisleadingIndentation]>;

Right, I know.  I'm wondering about what made you choose most?  I dont know our rules for warning groups, so hopefully someone else can comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75768/new/

https://reviews.llvm.org/D75768