[PATCH] D75700: [NFC] Let mangler accept GlobalDecl
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 6 08:14:01 PST 2020
yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028
else
- MC.mangleName(ND, Out);
+ MC.mangleName(GD, Out);
} else {
----------------
rjmccall wrote:
> What would be necessary in order for this to turn into just `mangleName(GD, Out)`? I suspect there are a lot of subtle assumptions between the different mangling methods today that could probably be broken down a bit and we'd end up with something much cleaner.
It seems to be just API changes. I will try changing them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75700/new/
https://reviews.llvm.org/D75700
More information about the cfe-commits
mailing list