[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

Fri Mar 6 04:57:44 PST 2020

aaron.ballman added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:43-45
+        llvm::errs()
+            << "Using ',' as a file extension delimiter is deprecated. Please "
+               "switch your configuration to use ';'.\n";
----------------
njames93 wrote:
> lebedev.ri wrote:
> > Can this spam be avoided?
> > It's going to be really intrusive, and it is not always possible to
> > just perform the migration (think: using more than one clang-tidy version.)
> > The deprecation message should be in the docs/releasenotes.
> That seems like a good idea. Would take a good many versions before the comma could safely be removed without fallout so people would get the warning too often and not be able to change it
FWIW, I was on the fence about this being a chatty diagnostic as well. I eventually figured that it was fine because it's going to `stderr` and it definitely gets the job done of letting people know. Most folks don't read release notes, so putting the information there is a good idea, but not really sufficient for warning about deprecation.

I don't think we have a better solution at hand and the point @lebedev.ri brings up about older versions is a valid one, so I agree, let's move this into the release notes rather than spamming the command line.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75621/new/

https://reviews.llvm.org/D75621