[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 5 16:58:42 PST 2020
nridge updated this revision to Diff 248630.
nridge marked 16 inline comments as done.
nridge added a comment.
Rebase onto D75479 <https://reviews.llvm.org/D75479> and address most review comments
Comments remaining to be addressed:
- revising the tests to exercise locateSymbolNamedTextuallyAt() directly
- comments related to fuzzy matching (I have an outstanding question about that)
Handling of dependent code has been deferred to a follow-up change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72874/new/
https://reviews.llvm.org/D72874
Files:
clang-tools-extra/clangd/FindSymbols.cpp
clang-tools-extra/clangd/FindSymbols.h
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/XRefs.h
clang-tools-extra/clangd/unittests/XRefsTests.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72874.248630.patch
Type: text/x-patch
Size: 15643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200306/a6cad1da/attachment.bin>
More information about the cfe-commits
mailing list