[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

Richard Sandiford via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 5 14:17:17 PST 2020


rsandifo-arm marked 2 inline comments as done.
rsandifo-arm added inline comments.


================
Comment at: clang/test/SemaCXX/sizeless-1.cpp:8
+// RUN: %clang_cc1 -fcxx-exceptions -fsyntax-only -verify -W -Wall -Wrange-loop-analysis -triple arm64-linux-gnu -target-feature +sve -std=c++17 %s
+// RUN: %clang_cc1 -fcxx-exceptions -fsyntax-only -verify -W -Wall -Wrange-loop-analysis -triple arm64-linux-gnu -target-feature +sve -std=gnu++17 %s
+
----------------
efriedma wrote:
> This is a lot of RUN lines (both here and in the other file).  Are you really getting any significant benefit from them?
Yeah, I probably went a bit overboard there.  The idea originally was to make sure that sizeless types worked with every standard, but of course that list is going to get out of date fast.  (E.g. it predated C++20.)

I've now restricted it to:

* the earliest standard
* standards that are tested explicitly in preprocessor conditions
* one gnu standard per test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75571/new/

https://reviews.llvm.org/D75571





More information about the cfe-commits mailing list