[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/lib/Parse/ParseStmtAsm.cpp:704
+      AQ = DeclSpec::AQ_goto;
+    else {
+      if (EndLoc.isValid())
----------------
aaron.ballman wrote:
> I would expect a diagnostic if the unknown token is anything other than a left paren.
That currently is is handled by the caller, see `if (Tok.isNot(tok::l_paren)) {` in `Parser::ParseAsmStatement` (line 762 of clang/lib/Parse/ParseStmtAsm.cpp).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75563/new/

https://reviews.llvm.org/D75563