[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 5 13:44:36 PST 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a minor nit.



================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:40
   SmallVector<StringRef, 5> Suffixes;
-  AllFileExtensions.split(Suffixes, Delimiter);
+  for (const char Delimiter : Delimiters) {
+    if (AllFileExtensions.contains(Delimiter)) {
----------------
Can drop the top-level `const` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75621/new/

https://reviews.llvm.org/D75621





More information about the cfe-commits mailing list