[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 5 09:18:14 PST 2020


baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:719-720
+      const auto *PSBR = dyn_cast<PathSensitiveBugReport>(&BR);
+      if (!PSBR)
+        return "";
+
----------------
NoQ wrote:
> Mmm, this is definitely impossible. We should change the `NoteTag` API to pass in a `PathSensitiveBugReport &`. My bad.
Good idea. For now I changed it to simple `cast<>()` without check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75514/new/

https://reviews.llvm.org/D75514





More information about the cfe-commits mailing list