[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 5 08:45:38 PST 2020
martong added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:7918
+
+ return nullptr;
+}
----------------
I think
```
return make_error<ImportError(ImportError::UnsupportedConstruct);
```
would be more appropriate here as this expresses that we do not support every aspect yet.
On the other hand a nullptr could be dereferenced later and thus could cause an unwanted crash.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64464/new/
https://reviews.llvm.org/D64464
More information about the cfe-commits
mailing list