[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 5 05:29:26 PST 2020


krasimir marked an inline comment as done.
krasimir added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:502
         Left->Type = TT_ObjCMethodExpr;
+      } else if (Style.isCpp() && InsideInlineASM) {
+        Left->Type = TT_InlineASMSymbolicNameLSquare;
----------------
hans wrote:
> Is the Style.isCpp() check necessary here?
> 
> If it's necessary, maybe that's because the setting of InsideInlineASM should be guarded by Style.isCpp() instead?
Good point! I think it's unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75675/new/

https://reviews.llvm.org/D75675





More information about the cfe-commits mailing list