[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In D75602#1906587 <https://reviews.llvm.org/D75602#1906587>, @thakis wrote:

> This broke building on my bots:
>
> http://45.33.8.238/linux/11862/step_4.txt
>
> `ld.lld: error: undefined symbol: clang::clangd::TUScheduler::InvalidatedError::ID`
>
> Looks like that is indeed declared in this change, but it doesn't have a definition.


Sorry about that, fixing. (I didn't see this on other linkers, maybe because the class itself wasn't used in this patch)



================
Comment at: clang-tools-extra/clangd/Cancellation.cpp:39
+      return true;
   return false; // Not in scope of a task.
 }
----------------
kadircet wrote:
> comment seems to be out-of-date.
> 
> `Either not cancelled or not in a cancellable task` ?
Yeah, just removed the comment, this is now pretty obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75602/new/

https://reviews.llvm.org/D75602