[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 4 11:47:50 PST 2020


njames93 added a comment.

In D75621#1905879 <https://reviews.llvm.org/D75621#1905879>, @jroelofs wrote:

> Preserve backwards compatibility of ',' as a delimiter (for now).
>
> > The llvm::StringRef::split function can take multiple split characters,
>
> AFAIU, that's for multi-character delimiters, not multiple delimiters.


Yeah just checked it out my bad.



================
Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:41
+  for (const char Delimiter : Delimiters) {
+    if (StringRef::npos != AllFileExtensions.find(Delimiter)) {
+      if (Delimiter == ',') {
----------------
`if (AllFileExtensions.contains(Delimeter)) {`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75621/new/

https://reviews.llvm.org/D75621





More information about the cfe-commits mailing list