[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 4 09:00:26 PST 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:58
+/// without any explicit user action.
+static TUScheduler::ASTActionInvalidation LikelyImplicit =
+    TUScheduler::InvalidateOnUpdate;
----------------
nit: i would actually keep `InvalidateOnUpdate` on the callsites, but up to you.

also constexpr instead of static ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75602/new/

https://reviews.llvm.org/D75602





More information about the cfe-commits mailing list