[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Yusra Syeda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 4 07:52:12 PST 2020


yusra.syeda added a comment.

Overall the patch LGTM, aside from 1 change we may want to make.



================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:531
+
+  bool isCXXGlobalInitAndDtorFuncInternal() const override { return false; }
+
----------------
Perhaps adding a check to see if the OS is AIX before setting linkage to external will be useful here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74166/new/

https://reviews.llvm.org/D74166





More information about the cfe-commits mailing list