[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.h:73
     virtual void onDiagnosticsReady(PathRef File,
+                                    const llvm::json::Value &Version,
                                     std::vector<Diag> Diagnostics) {}
----------------
can we rather have `Optional<int>`s here(both for callbacks and `addDocument`)?

as clangdserver layer doesn't touch json objects at all currently.


================
Comment at: clang-tools-extra/clangd/Compiler.h:49
+  // Version identifier for Contents, provided by the client and opaque to us.
+  llvm::json::Value Version = nullptr;
   // Prevent reuse of the cached preamble/AST. Slow! Useful to workaround
----------------
again this (and other clangdserver structs) can hold a optional<int> right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75582/new/

https://reviews.llvm.org/D75582