[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/Selection.cpp:612
+      // underlying TypeLoc.
+      // FIXME: Unfortunately this doesn't work, even though RecursiveASTVisitor
+      // traverses the underlying TypeLoc inside DeclarationName, it is null for
----------------
sammccall wrote:
> can you check this at HEAD?
> IIRC this was related to the reason kythe was failing to report constructors as references to the class, which is now fixed. But I don't know if they fixed the AST or worked around it.
nope, seems like still broken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75106/new/

https://reviews.llvm.org/D75106