[PATCH] D75473: [clang-format] parse C# object initialisers
Jonathan B Coe via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 3 15:00:30 PST 2020
jbcoe marked an inline comment as done.
jbcoe added inline comments.
================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1978
+ if (FormatTok->is(tok::l_paren))
+ parseParens();
+
----------------
krasimir wrote:
> I don't understand why this is needed, and removing this `if` does not cause any tests to fail.
> Please add a test case that will fail if we remove this `if`, or consider removing otherwise.
I'll remove this for now and put together a follow up patch with test cases for more obscure object initializer use cases.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75473/new/
https://reviews.llvm.org/D75473
More information about the cfe-commits
mailing list