[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

Tue Mar 3 13:14:10 PST 2020

sammccall marked an inline comment as done.
sammccall added inline comments.

================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5006
+      if (/*Inserted*/ R.second ||
+          std::make_tuple(M.Operator, M.ArgTypes.hasValue(),
+                          M.ResultType != nullptr) >
----------------
nridge wrote:
> So `Colons` is more info than `Arrow` which is more info than `Dot`? Is there some intuition behind that?
no, it's basically arbitrary.
I don't think collisions between these are likely and worth dealing with carefully, but making the choice consistently seems worthwhile to me, in case someone ever has to debug it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73649/new/

https://reviews.llvm.org/D73649