[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 3 13:14:08 PST 2020
njames93 marked an inline comment as done.
njames93 added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1
-// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion
-//
----------------
alexfh wrote:
> IIRC, some of the modernize- checks were meant to be useful to make the pre-C++11 code compile in C++11. This check is an example of this (maybe the only one?). Limiting the check to C++11 and deleting this test is a bit too radical.
I'm lost, this check is all about replacing assignment of pointer to 0 with `nullptr` a keyword which doesn't exist pre c++11, so this test case will just result in invalid code. Or am I missing the point?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75538/new/
https://reviews.llvm.org/D75538
More information about the cfe-commits
mailing list