[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

Tue Mar 3 09:05:59 PST 2020

ahatanak added inline comments.

================
Comment at: test/Import/objc-arc/Inputs/cleanup-objects.m:6
+id getObj(int c, id a) {
+  // Commenting out the following line because AST importer crashes when trying
+  // to import a BlockExpr.
----------------
martong wrote:
> Perhaps then this patch depends on another patch which implements the import of a BlockExpr?
> Or maybe the branch `if (auto *BD = From.dyn_cast<BlockDecl *>())` should be left out from the ASTImporter code, and this way BlockExpr and BlockDecl would be implemented later in another patch.
Yes, I removed it from `ASTImporter::Import` and left a FIXME comment there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64464/new/

https://reviews.llvm.org/D64464