[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 3 03:04:20 PST 2020


alexfh added a comment.

In D75441#1901071 <https://reviews.llvm.org/D75441#1901071>, @gribozavr2 wrote:

> > I think my preference is to go with isLanguageVersionSupported() and not use base classes.
>
> +1, I can see this working, but the introduction of new concepts does not seem like it pulls its weight given the tiny amount of boilerplate that they eliminate.


+1, I'm definitely against adding base classes for supported language versions. The increase in the API surface doesn't seem to pay off here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75441/new/

https://reviews.llvm.org/D75441





More information about the cfe-commits mailing list