[PATCH] D75423: [OpenCL] Mark pointers to constant address space as invariant

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 2 10:21:01 PST 2020


yaxunl added a comment.

In D75423#1901362 <https://reviews.llvm.org/D75423#1901362>, @rjmccall wrote:

> Okay, then I have no problem taking a patch for this into IRGen.  But I think it should be fine to do this by adding the invariant-load metadata when loading from an l-value instead of injecting invariant-groups into l-value emission.


The pointer to constant may be casted to a generic pointer then loaded. If we only mark load from pointer to constant, we loses information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75423/new/

https://reviews.llvm.org/D75423





More information about the cfe-commits mailing list