[PATCH] D75056: [Driver] Default to -fno-common for all targets

[James Y Knight via Phabricator via cfe-commits]

jyknight accepted this revision.
jyknight added a comment.

Looks good modulo minor comments.



================
Comment at: clang/test/CodeGen/microsoft-no-common-align.c:1
 // RUN: %clang_cc1 -triple x86_64-windows-msvc -emit-llvm -o - %s | FileCheck %s
 typedef float TooLargeAlignment __attribute__((__vector_size__(64)));
----------------
I think this test should specify -fcommon, since it's explicitly testing a bug we had in common support?


================
Comment at: clang/test/CodeGenOpenCL/amdgpu-nullptr.cl:182-184
 // Tentative definition of global variables with non-zero initializer
 // cannot have common linkage since common linkage requires zero initialization
 // and does not have explicit section.
----------------
Sounds like this test is also expecting to check -fcommon behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75056/new/

https://reviews.llvm.org/D75056