[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

Mon Mar 2 08:12:04 PST 2020

kadircet added a comment.

In D75429#1901120 <https://reviews.llvm.org/D75429#1901120>, @njames93 wrote:

> In D75429#1901073 <https://reviews.llvm.org/D75429#1901073>, @kadircet wrote:
>
> > In D75429#1901018 <https://reviews.llvm.org/D75429#1901018>, @njames93 wrote:
> >
> > > - Fixed clang tidy warning, wont fix format as it's contradicting with the style of the rest of the function
> >
> >
> > I believe the formatting linter messages results from the fact that you are finishing the structs with a `}` on a newline, it should be right next to expected output, without any newlines in between.
>
>
> The linter messages are actually to do with the no new line after the `{` and bad indentation inside the braced init list, however that's how the rest look.

yes it just suggests `a` formatting, but `the` formatting you want is dropping the new line just before `}` and hopefully that should also make linter happy.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75429/new/

https://reviews.llvm.org/D75429