[clang] 736385c - EHScopeStack::Cleanup has virtual functions so the destructor should be too.

Simon Pilgrim via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 2 07:07:15 PST 2020


Author: Simon Pilgrim
Date: 2020-03-02T15:06:34Z
New Revision: 736385c0b49d42f398ffa1458883f0d182178ef4

URL: https://github.com/llvm/llvm-project/commit/736385c0b49d42f398ffa1458883f0d182178ef4
DIFF: https://github.com/llvm/llvm-project/commit/736385c0b49d42f398ffa1458883f0d182178ef4.diff

LOG: EHScopeStack::Cleanup has virtual functions so the destructor should be too.

Fixes cppcheck warning.

Added: 
    

Modified: 
    clang/lib/CodeGen/EHScopeStack.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/EHScopeStack.h b/clang/lib/CodeGen/EHScopeStack.h
index 0ed67aabcd62..4dd3da3e90e7 100644
--- a/clang/lib/CodeGen/EHScopeStack.h
+++ b/clang/lib/CodeGen/EHScopeStack.h
@@ -148,7 +148,7 @@ class EHScopeStack {
     virtual void anchor();
 
   protected:
-    ~Cleanup() = default;
+    virtual ~Cleanup() = default;
 
   public:
     Cleanup(const Cleanup &) = default;


        


More information about the cfe-commits mailing list