[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4860
+      return;
+    if (auto *CSE = llvm::dyn_cast<ConceptSpecializationExpr>(E)) {
+      // If the concept is
----------------
nridge wrote:
> clang-tidy gives me an `'auto *CSE' can be declared as 'const auto *CSE'` here, and several similar diagnostics below.
> 
> Not sure if that's something we want to obey, or alter our configuration to silence it.
That warning will go away next time the bot updates the version of clang tidy it uses. It was decided to reduce the constraints on diagnosing that check inside llvm but that hasn't reached the pre merge bot. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73649/new/

https://reviews.llvm.org/D73649