[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 1 08:47:50 PST 2020


Szelethus marked 5 inline comments as done.
Szelethus added a comment.
Herald added subscribers: martong, steakhal.

I've spent a lot of time on this code, and I don't think it'd be a great idea to do everything in a single step. Collapsing `CallExpr, ProgramState` into `CallEvent` is a shockingly a non-trivial task. While I'm happy to not commit this patch before uploading a solution to that problem, I'd prefer (and I think you would too!) to do them in followup patches.

The point of this revision was to drop in `CallDescriptionMap` -- I like to think that it introduces no new problems, it just doesn't solve many existing ones :^)

edit: I will soon address the inlines and other comments with an update


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68165/new/

https://reviews.llvm.org/D68165





More information about the cfe-commits mailing list