[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Sun Mar 1 07:34:51 PST 2020

bader added a comment.

In D72857#1895649 <https://reviews.llvm.org/D72857#1895649>, @bader wrote:

> In D72857#1895625 <https://reviews.llvm.org/D72857#1895625>, @thakis wrote:
>
> > This landed here: https://github.com/llvm/llvm-project/commit/bd97704eaaaab5a95ecb048ce343c1a4be5d94e5
> >
> > It broke tests on mac: http://45.33.8.238/mac/9011/step_7.txt
> >
> > Please take a look, and if it takes a while please revert while you investigate.
>
>
> @thakis, thank for letting me know. I've reverted it at 740ed617f7d4d16e7883636c5eff994f8be7eba4 <https://reviews.llvm.org/rG740ed617f7d4d16e7883636c5eff994f8be7eba4>. Sorry for inconvenience.

@thakis, could you help to find the logs for the "build" step?
I don't have access to a Mac system and I can't reproduce the problem on my Linux system, but just looking at the log it looks like that changes to clang/include/clang/Driver/Options.td were not applied.

  <stdin>:7:42: note: possible intended match here
  clang: warning: argument unused during compilation: '-fsycl' [-Wunused-command-line-argument]

I'd like to make sure that clang is built with the patch applied.

I also noticed that on your system uses gn instead of cmake. Can it be that there is a missing dependency in GN files, which lead to skipping clang re-build?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72857/new/

https://reviews.llvm.org/D72857