[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy
Alexandre Ganea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 28 19:23:45 PST 2020
aganea updated this revision to Diff 247400.
aganea added a comment.
Fix clang-formatting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75373/new/
https://reviews.llvm.org/D75373
Files:
clang/lib/Driver/ToolChains/Hurd.cpp
clang/lib/Driver/ToolChains/Hurd.h
Index: clang/lib/Driver/ToolChains/Hurd.h
===================================================================
--- clang/lib/Driver/ToolChains/Hurd.h
+++ clang/lib/Driver/ToolChains/Hurd.h
@@ -10,13 +10,14 @@
#define LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_Hurd_H
#include "Gnu.h"
+#include "Linux.h"
#include "clang/Driver/ToolChain.h"
namespace clang {
namespace driver {
namespace toolchains {
-class LLVM_LIBRARY_VISIBILITY Hurd : public Generic_ELF {
+class LLVM_LIBRARY_VISIBILITY Hurd : public Linux {
public:
Hurd(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args);
@@ -27,9 +28,9 @@
AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args) const override;
- virtual std::string computeSysRoot() const;
+ std::string computeSysRoot() const override;
- virtual std::string getDynamicLinker(const llvm::opt::ArgList &Args) const;
+ std::string getDynamicLinker(const llvm::opt::ArgList &Args) const override;
std::vector<std::string> ExtraOpts;
Index: clang/lib/Driver/ToolChains/Hurd.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Hurd.cpp
+++ clang/lib/Driver/ToolChains/Hurd.cpp
@@ -61,9 +61,8 @@
return Triple.isArch32Bit() ? "lib" : "lib64";
}
-Hurd::Hurd(const Driver &D, const llvm::Triple &Triple,
- const ArgList &Args)
- : Generic_ELF(D, Triple, Args) {
+Hurd::Hurd(const Driver &D, const llvm::Triple &Triple, const ArgList &Args)
+ : Linux(D, Triple, Args) {
std::string SysRoot = computeSysRoot();
path_list &Paths = getFilePaths();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75373.247400.patch
Type: text/x-patch
Size: 1670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200229/9bb40377/attachment.bin>
More information about the cfe-commits
mailing list